Skip to content

Conversation

glbrntt
Copy link
Contributor

@glbrntt glbrntt commented Sep 15, 2022

Motivation:

SwiftNIO periodically drops support for older Swift versions. Now that 5.7 has been released, 5.4 will be dropped.

Modifications:

  • Remove 5.4 specific Package.swift and docker-compose
  • Update the 5.7 docker-compose to use the released 5.7 and move from focal (2004) to jammy (2204)
  • Remove unused swiftformat from Dockerfile
  • Update tools version in syscall wrapper tests to 5.5
  • Update docs

Results:

Minimum Swift version is 5.5

@glbrntt glbrntt added the 🆕 semver/minor Adds new public API. label Sep 15, 2022
@glbrntt glbrntt marked this pull request as ready for review September 28, 2022 09:16
@glbrntt glbrntt requested a review from Lukasa September 28, 2022 09:17
@glbrntt
Copy link
Contributor Author

glbrntt commented Sep 28, 2022

This change appears to have cause allocations to change in 5.5 and 5.6 (and presumably 5.7). 1_reqs_1000_conn has regressed 👀...

@glbrntt
Copy link
Contributor Author

glbrntt commented Sep 28, 2022

This change appears to have cause allocations to change in 5.5 and 5.6 (and presumably 5.7). 1_reqs_1000_conn has regressed 👀...

These must come from GHSA-7fj7-39wj-c64f. Fixing in a separate PR.

@yim-lee
Copy link
Member

yim-lee commented Sep 28, 2022

CI (including performance jobs) updated. @swift-server-bot test this please

@yim-lee
Copy link
Member

yim-lee commented Sep 28, 2022

@swift-server-bot test this please

Motivation:

SwiftNIO periodically drops support for older Swift versions. Now that
5.7 has been released, 5.4 will be dropped.

Modifications:

- Remove 5.4 specific Package.swift and docker-compose
- Update the 5.7 docker-compose to use the released 5.7 and move from
  focal (2004) to jammy (2204)
- Remove unused swiftformat from Dockerfile
- Update tools version in syscall wrapper tests to 5.5
- Update docs

Results:

Minimum Swift version is 5.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🆕 semver/minor Adds new public API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants