Skip to content

Not retry calling close(...) when EINTR is reported. #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2018
Merged

Not retry calling close(...) when EINTR is reported. #217

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions Sources/NIO/System.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,8 +184,20 @@ internal enum Posix {

@inline(never)
public static func close(descriptor: CInt) throws {
_ = try wrapSyscall {
sysClose(descriptor)
let res = sysClose(descriptor)
if res == -1 {
let err = errno

// There is really nothing "sane" we can do when EINTR was reported on close.
// So just ignore it and "assume" everything is fine == we closed the file descriptor.
//
// For more details see:
// - https://bugs.chromium.org/p/chromium/issues/detail?id=269623
// - https://lwn.net/Articles/576478/
if err != EINTR {
assert(!isBlacklistedErrno(err), "blacklisted errno \(err) \(strerror(err)!)")
throw IOError(errnoCode: err, function: "close")
}
}
}

Expand Down