fixed #202 #208
Merged
fixed #202 #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Sources/NIO/ChannelInvoker.swift
Outdated
| triggerUserOutboundEvent(event, promise: promise) | ||
| return promise.futureResult | ||
| } | ||
|
|
||
| private func newPromise() -> EventLoopPromise<Void> { | ||
| return eventLoop.newPromise() | ||
| public func newPromise<T>(file: StaticString = #file, line: UInt = #line) -> EventLoopPromise<T> { |
There was a problem hiding this comment.
@tib can we keep this private for now ? Also I think we can just keep the old return type to remove some typing ;)
There was a problem hiding this comment.
Sure, I'll make the changes.
|
@tib can you please amend your commit to follow our commit template for the message ? Basically what you added here as description in the issue :) Also please squash. Thanks! |
|
@swift-nio-bot test this please |
|
@normanmaurer I made the changes, now it should be fine. |
|
@tib awesome... will merge once CI finish |
normanmaurer
approved these changes
Mar 21, 2018
|
@swift-nio-bot test this please |
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced some new parameters.
Motivation:
I just wanted to fix #202 :)
Modifications:
Created new parameters for the file and line newPromise method inside ChannelOutboundInvoker.
Result:
File and line numbers are now passed to the eventLoop object, all unit tests have been passed.