Add closure taking write API #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves the ergonomics of writing to Registers with a new write method
taking a builder closure.
Instead of requiring users to form a write value with following clunky
dance:
``` swift
var w = Foo.Write(Foo.Raw(0))
w.x = 1
w.y = true
foo.write(w)
```
The new `write<T>(_: (inout Value.Write) -> (T)) -> T` method allows
them to use the following pattern:
```swift
foo.write { w in
w.x = 1
w.y = true
}
```
Fixes #66
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the ergonomics of writing to Registers with a new write method taking a builder closure.
Instead of requiring users to form a write value with following clunky dance:
The new
write<T>(_: (inout Value.Write) -> (T)) -> Tmethod allows them to use the following pattern:Fixes #66