Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split parts with FoundationNetworking dependency into its own library #77

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

guoye-zhang
Copy link
Contributor

Resolves #76

@guoye-zhang guoye-zhang added the ⚠️ semver/major Breaks existing public API. label Dec 7, 2024
Copy link

@ekinnear ekinnear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth looking into the FoundationEssentials option

@guoye-zhang
Copy link
Contributor Author

FoundationEssentials is a concept in SwiftFoundation, not the compiler built-in Foundation. Not sure if it requires bringing in another package.

Copy link
Member

@weissi weissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much!

@guoye-zhang
Copy link
Contributor Author

I can't merge this PR due to several checks failing, but I think these are expected to fail

@Lukasa
Copy link

Lukasa commented Dec 9, 2024

Yeah, they're expected to fail. Can you update the readme to clarify that we want users to depend on a range? You want to say something like this:

Swift HTTP Types 2.0.0 was released in December 2024. The only breaking change between Swift HTTP Types 2.0.0 and 1.0.0 was moving a small number of values from HTTPTypesFoundation into a new module, HTTPTypesFoundationNetworking. For any users not affected by this change, it's safe to depend on either the 1.0.0 or 2.0.0 series of releases.

To do so, please use the following dependency in your Package.swift:

.package(url: "https://github.com/apple/swift-http-types.git", "1.0.0" ..< "3.0.0"),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠️ semver/major Breaks existing public API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

import HTTPTypesFoundation pulls in FoundationNetworking
4 participants