support URLSession concurrency method in Swift 6(Linux, Windows) #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zunda-pixel
commented
Jul 14, 2024
zunda-pixel
commented
- support URLSession concurrency method in Swift 6(Linux, Windows)
- add DerivedData to .gitignore for Xcode
zunda-pixel
changed the title
|
@swift-ci test |
|
@jrflat Would you take a look at this? |
zunda-pixel
commented
Jul 15, 2024
|
|
||
| @available(macOS 12.0, iOS 15.0, watchOS 8.0, tvOS 15.0, *) | ||
| extension URLSession { |
There was a problem hiding this comment.
AsyncBytes supports Apple Platform, but doesn't support Linux and Windows.
swiftlang/swift-corelibs-foundation#3036
jrflat
reviewed
Jul 15, 2024
|
|
||
| #endif | ||
|
|
||
| #if os(macOS) || os(iOS) || os(watchOS) || os(tvOS) || os(visionOS) |
There was a problem hiding this comment.
Can we guard only the bytes func with this directive? That way we don't have to do the #endif/#if and split the extension. LGTM otherwise!
There was a problem hiding this comment.
I put it all together in one extension.
jrflat
approved these changes
Jul 16, 2024
|
@swift-ci please test |
|
@swift-ci test |
guoye-zhang
approved these changes
Jul 16, 2024
guoye-zhang
reviewed
Jul 16, 2024
.gitignore
Outdated
| @@ -12,3 +12,4 @@ Package.resolved | |||
|
|
|||
| # DocC generated files | |||
| .docc-build | |||
| DerivedData | |||
There was a problem hiding this comment.
Would you move it up to the Xcode section and delete one of the .xcodes?
There was a problem hiding this comment.
I moved it under .xcode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.