Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connect-UDP-Listen to Connect-UDP-Bind #47

Merged
merged 1 commit into from
May 13, 2024
Merged

Connect-UDP-Listen to Connect-UDP-Bind #47

merged 1 commit into from
May 13, 2024

Conversation

guoye-zhang
Copy link
Contributor

No description provided.

@guoye-zhang guoye-zhang requested review from Lukasa and ekinnear April 24, 2024 00:18
@guoye-zhang
Copy link
Contributor Author

@swift-ci test

FranzBusch
FranzBusch reviewed Apr 24, 2024
View reviewed changes
Copy link
Member

@FranzBusch FranzBusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we still keep the deprecated and non public field names around?

@guoye-zhang
Copy link
Contributor Author

@FranzBusch I'm trying to minimize the difference between internal source and public source. These has to be defined in this file since init(rawName: String, canonicalName: String) is private, and they are being used in Network framework.

@guoye-zhang guoye-zhang merged commit a584b11 into apple:main May 13, 2024
3 checks passed
@guoye-zhang guoye-zhang deleted the connect-udp-bind branch May 13, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FranzBusch FranzBusch FranzBusch approved these changes

@ekinnear ekinnear ekinnear approved these changes

@Lukasa Lukasa Lukasa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@guoye-zhang @Lukasa @ekinnear @FranzBusch