Skip to content

Remove all instances of AskResponse.wait() use #998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2022
Merged

Remove all instances of AskResponse.wait() use #998

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions Tests/DistributedActorsTests/ActorAskTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ final class ActorAskTests: ClusterSystemXCTestCase {
let replyTo: _ActorRef<String>
}

func test_ask_forSimpleType() throws {
func test_ask_forSimpleType() async throws {
let behavior: _Behavior<TestMessage> = .receiveMessage {
$0.replyTo.tell("received")
return .stop
Expand All @@ -32,12 +32,12 @@ final class ActorAskTests: ClusterSystemXCTestCase {

let response = ref.ask(for: String.self, timeout: .seconds(1)) { TestMessage(replyTo: $0) }

let result = try response.wait()
let result = try await response.value

result.shouldEqual("received")
}

func test_ask_shouldSucceedIfResponseIsReceivedBeforeTimeout() throws {
func test_ask_shouldSucceedIfResponseIsReceivedBeforeTimeout() async throws {
let behavior: _Behavior<TestMessage> = .receiveMessage {
$0.replyTo.tell("received")
return .stop
Expand All @@ -47,12 +47,12 @@ final class ActorAskTests: ClusterSystemXCTestCase {

let response = ref.ask(for: String.self, timeout: .seconds(1)) { TestMessage(replyTo: $0) }

let result = try response.wait()
let result = try await response.value

result.shouldEqual("received")
}

func test_ask_shouldFailIfResponseIsNotReceivedBeforeTimeout() throws {
func test_ask_shouldFailIfResponseIsNotReceivedBeforeTimeout() async throws {
let behavior: _Behavior<TestMessage> = .receiveMessage { _ in
.stop
}
Expand All @@ -61,16 +61,16 @@ final class ActorAskTests: ClusterSystemXCTestCase {

let response = ref.ask(for: String.self, timeout: .seconds(1)) { TestMessage(replyTo: $0) }

let error = try shouldThrow {
_ = try response.wait()
let error = try await shouldThrow {
_ = try await response.value
}

guard case RemoteCallError.timedOut = error else {
throw testKit.fail("Expected RemoteCallError.timedOut, got \(error)")
}
}

func test_ask_shouldCompleteWithFirstResponse() throws {
func test_ask_shouldCompleteWithFirstResponse() async throws {
let behavior: _Behavior<TestMessage> = .receiveMessage {
$0.replyTo.tell("received:1")
$0.replyTo.tell("received:2")
Expand All @@ -81,7 +81,7 @@ final class ActorAskTests: ClusterSystemXCTestCase {

let response = ref.ask(for: String.self, timeout: .milliseconds(1)) { TestMessage(replyTo: $0) }

let result = try response.wait()
let result = try await response.value

result.shouldEqual("received:1")
}
Expand Down Expand Up @@ -185,15 +185,15 @@ final class ActorAskTests: ClusterSystemXCTestCase {
try p.expectMessage(msg)
}

func test_ask_onDeadLetters_shouldPutMessageIntoDeadLetters() throws {
func test_ask_onDeadLetters_shouldPutMessageIntoDeadLetters() async throws {
let ref = system.deadLetters.adapt(from: AnswerMePlease.self)

let result = ref.ask(for: String.self, timeout: .milliseconds(300)) {
AnswerMePlease(replyTo: $0)
}

let error = try shouldThrow {
try result.wait()
let error = try await shouldThrow {
try await result.value
}

guard case RemoteCallError.timedOut = error else {
Expand Down