Skip to content

Silence OpLogDistributedReceptionist.sendAckOps timeout logs #996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 9, 2022
Merged

Silence OpLogDistributedReceptionist.sendAckOps timeout logs #996

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cb926a9
Silence OpLogDistributedReceptionist.sendAckOps timeout logs
PopFlamingo Jul 9, 2022
a73d58b
Merge cases
PopFlamingo Jul 9, 2022
94f8b27
Improve a bit the comment
PopFlamingo Jul 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Sources/DistributedActors/Cluster/Reception/OperationLogDistributedReceptionist.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -629,8 +629,9 @@ extension OpLogDistributedReceptionist {
try await peerReceptionistRef.ackOps(until: latestAppliedSeqNrFromPeer, by: self)
} catch {
switch error {
case RemoteCallError.clusterAlreadyShutDown:
// ignore silently; this often happens during tests when we terminate systems while interacting with them
case RemoteCallError.clusterAlreadyShutDown, is TimeoutError:
// ignore silently; clusterAlreadyShutDown often happens during tests when we terminate systems
// while interacting with them. TimeoutErrors are also expected to happen sometimes.
()
default:
log.error("Error: \(error)")
Expand Down