Add API to 'await joining cluster' #972
Conversation
yim-lee
changed the title
| guard let foundMember = membership.uniqueMember(node) else { | ||
| throw Cluster.MembershipError.notFound(node, in: membership) | ||
| } | ||
|
|
There was a problem hiding this comment.
Oh sorry to bother you but I thought of another case...
If a node was removed BEFORE, we'll have a tombstone for it inside the private var _associationTombstones: [UniqueNode: Association.Tombstone] protected by _associationsLock. If it is in there, we should return that the member was .removed
You can "make up" a member for a removed node by creating a Member( from the unique node and put .unreachable and .removed in there 👍
This could be in a separate PR 👍
| \(lastErrorMessage) | ||
| """ | ||
| } | ||
| } |
There was a problem hiding this comment.
Looks good but Perhaps must be wrapped in "MembershipError(\(self), details: <the nice strings>")? Otherwise might be weird not seeing what type the error was?
ktoso
left a comment
ktoso
left a comment
There was a problem hiding this comment.
LGTM!
Minor potential addition to handle removed nodes better
|
Will amend the wording, look at the failure and merge, thank you! :) |
2 participants
Resolves #948
Depends on #969. Please look at 8f46d04 only.