Implement remoteCall without ask actors #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

ktoso merged 3 commits into apple:main from yim-lee:iss947

Jun 8, 2022

Member

yim-lee commented Jun 8, 2022

Resolves #947


          Implement remoteCall without ask actors

b8c1fe9

Resolves apple#947

ktoso reviewed

View reviewed changes

Sources/DistributedActors/Cluster/Transport/TransportPipelines.swift Show resolved Hide resolved

ktoso reviewed

View reviewed changes

Sources/DistributedActors/Cluster/Transport/TransportPipelines.swift Show resolved Hide resolved

ktoso reviewed

View reviewed changes

Sources/DistributedActors/Cluster/Transport/TransportPipelines.swift Show resolved Hide resolved

ktoso reviewed

View reviewed changes

Sources/DistributedActors/ClusterSystem.swift Show resolved Hide resolved

ktoso reviewed

View reviewed changes

Sources/DistributedActors/ClusterSystem.swift Show resolved Hide resolved

ktoso reviewed

View reviewed changes

Sources/DistributedActors/ClusterSystem.swift Show resolved Hide resolved

ktoso mentioned this pull request

Remove InvocationBehavior once we moved all the way to remoteCalls #957

Open

yim-lee added 2 commits

June 7, 2022 23:47


          Keep InvocationBehavior

a7c8dd6


          Fix formatting

8eff4df

Member Author

yim-lee commented Jun 8, 2022

Tests pass but there are a bunch of these in test logs:

23:56:13 2022-06-08T06:56:13+0000 error /system/receptionist : actor/id=/system/receptionist actor/path=/system/receptionist Error: timedOut(DistributedActors.TimeoutError(message: "Remote call timed out", timeout: TimeAmount(5s, nanoseconds: 5000000000)))

23:56:13 ERROR: Cannot schedule tasks on an EventLoop that has already shut down. This will be upgraded to a forced crash in future SwiftNIO versions.

They are not related.

One can reproduce the EL-already-shut-down errors by running ClusterSystemTests alone (even just the ClusterSystemTests.test_remoteCall subset would do).

The receptionist error might have been caused by the changes in InvocationBehavior.

Member

ktoso commented Jun 8, 2022

I dug deep into this and it will need some timer scheduling changes -- too large to do in this PR.

We figured it out with @Lukasa and I'll document a plan in a new ticket.

ktoso merged commit 9bfc901 into apple:main

yim-lee deleted the iss947 branch

June 8, 2022 17:37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet