More API and documentation cleanups #954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
force-pushed
the
wip-cleanups
branch
2 times, most recently
from
68436ee to
ee8093f
Compare
weissi
reviewed
Jun 8, 2022
| let system = self.actorSystem | ||
| system?.shutdownLock.lock() | ||
| defer { | ||
| system?.shutdownLock.unlock() |
Member
There was a problem hiding this comment.
@ktoso this isn't legal code because you may lock and unlock on different threads which is UB and will likely crash. So you can never hold a mutex/lock across an await. I'd recommend only using the withLock { ... } version which will prevent you from doing this.
Member
Author
There was a problem hiding this comment.
Oh boy, you're right of course -- moving to DispatchSemaphore. Thanks for spotting this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.