Skip to content

Conversation

@segabor
Copy link

@segabor segabor commented Apr 3, 2022

Adapt codebase for Swift 5.6 release version

Motivation:

I wanted to try out Distributed Actors library on my Mac having Swift 5.6 release installed but it could not even compile. So I decided to fix the code base.

Modifications:

I applied the following fixes to the codebase,

  • Fixed and updated SwiftSyntax dependency in Package.swift
  • Fixed SwiftSyntax import in GenActions Swift source
  • Made a test class final to meet a requirement imposed by Actorable protocol.

Result:

The whole codebase now compiles with Swift 5.6. Also the full test suite is passed. All the changes made on a MacBook Pro mid 2015 running the latest macOS (Monterey 12.3.1) and Xcode 13.3.

@swift-server-bot
Copy link

Can one of the admins verify this patch?

6 similar comments
@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@tomerd
Copy link
Member

tomerd commented Apr 3, 2022

@swift-server-bot test this please

@segabor
Copy link
Author

segabor commented Apr 4, 2022

Not sure if this is something that can be easily fixed but my knowledge is quite limited. So, SwiftSyntaxParser type has been extracted to a separate product but the binary release for Swift 5.4.x does not contain this change.

There are multiple ways it can be fixed,

  1. Ship new SwiftSyntax release for older Swift versions and update Package.swift to include them
  2. Hack around Package.swift and make sure to include the right dependency (SwiftSyntax vs SwiftSyntaxParser) based on what's in the binary dep.
  3. Drop support of older Swift versions

@segabor segabor changed the title Release/0.x Adapt codebase for Swift 5.6 release version Apr 4, 2022
@segabor
Copy link
Author

segabor commented Apr 5, 2022

@tomerd can I get an automated test please?

@ktoso
Copy link
Member

ktoso commented Apr 6, 2022

The release/0.x branch can require Swift 5.6, that's okey -- no need for backwards compatibility.
All our adopters are able to move on to it quickly.

@ktoso
Copy link
Member

ktoso commented Apr 6, 2022

@swift-server-bot test this please

@ktoso
Copy link
Member

ktoso commented Apr 6, 2022

Yeah it is known that this didn't right now build on 5.6 because issues with SwiftSyntax.
There was also a blocker issue in the syntax release itself, but that got solved.

If you're interested I'd really welcome the help on getting us green here on this branch and 5.4 and 5.6.
If we can't make it work on 5.4 anymore we could consider dropping it tbh as this isn't a stable release branch.

@ktoso
Copy link
Member

ktoso commented Apr 6, 2022

Oh actually, seems everything is fixed with Syntax now, thank you :-) I'll fix the formatting issue and we can merge 🥳

@ktoso
Copy link
Member

ktoso commented Apr 6, 2022

@swift-server-bot test this please

@segabor
Copy link
Author

segabor commented Apr 6, 2022

@ktoso happy to help!

@ktoso
Copy link
Member

ktoso commented Apr 6, 2022

And we're green :-)

Thanks for the poke here, I was recently head down on the main branch and updating us to Swift 5.7 and some final compiler work to make it possible, please look forward to the main branch becoming stable very soon! 🥳

@ktoso ktoso merged commit 9fc4710 into apple:release/0.x Apr 6, 2022
@ktoso ktoso added this to the 0.6.11 milestone Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants