-
Notifications
You must be signed in to change notification settings - Fork 78
Adapt codebase for Swift 5.6 release version #876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can one of the admins verify this patch? |
6 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
@swift-server-bot test this please |
|
Not sure if this is something that can be easily fixed but my knowledge is quite limited. So, There are multiple ways it can be fixed,
|
|
@tomerd can I get an automated test please? |
|
The release/0.x branch can require Swift 5.6, that's okey -- no need for backwards compatibility. |
|
@swift-server-bot test this please |
|
Yeah it is known that this didn't right now build on 5.6 because issues with SwiftSyntax. If you're interested I'd really welcome the help on getting us green here on this branch and 5.4 and 5.6. |
|
Oh actually, seems everything is fixed with Syntax now, thank you :-) I'll fix the formatting issue and we can merge 🥳 |
|
@swift-server-bot test this please |
|
@ktoso happy to help! |
|
And we're green :-) Thanks for the poke here, I was recently head down on the main branch and updating us to Swift 5.7 and some final compiler work to make it possible, please look forward to the main branch becoming stable very soon! 🥳 |
Adapt codebase for Swift 5.6 release version
Motivation:
I wanted to try out Distributed Actors library on my Mac having Swift 5.6 release installed but it could not even compile. So I decided to fix the code base.
Modifications:
I applied the following fixes to the codebase,
Result:
The whole codebase now compiles with Swift 5.6. Also the full test suite is passed. All the changes made on a MacBook Pro mid 2015 running the latest macOS (Monterey 12.3.1) and Xcode 13.3.