Avoid arithmetic overflow for mailboxCount metric #803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
budde
commented
Jun 29, 2021
Comment on lines
497
to
498
| "status": "\(status)", | ||
| "processedActivations": "\(processedActivations)" |
Contributor
Author
There was a problem hiding this comment.
Not sure if the extra metadata is necessary or not (or if the formatting is appropriate) but figured the more info the better
Member
There was a problem hiding this comment.
Yeah always good to have more info here, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid arithmetic overflow for mailboxCount metric
Motivation:
It seems that something can cause a mailbox to close with its
processedActivationscount greater than the incoming message count for the run that resulted in the mailbox close. In this scenario, an arithmetic overflow occurs when trying to record the finalmailboxCountmetric.Modifications:
Only record the
mailboxCountmetric if the processedActivations count is less than or equal to the message count. Record awarnlog otherwise.Result:
warnlog that can be used for additional root cause analysis