-
Notifications
You must be signed in to change notification settings - Fork 78
+dispatcher offer GCD dispatcher; Enables Actors on DispatchQueues #703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does it do though?
*Executor(comment right below) might be more fitting?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah good point... The word "scheduler" is sadly very overloaded -- could be "at some point in time scheduler" or those "just thread pool manager" – in libs like Rx or Combine those are called schedulers and technically it's the right word...
Akka wording was always "dispatcher" though I guess it's not necessarily the best... There the other words on the JVM are executors indeed. WDYT @drexin ? I'm somehow not in love with "dispatcher" the more i looked at it; "It schedules the actors execution" is kind of the right phrase, but "it executes the actor" also sounds correct I guess (though a bit macabre 😆 though actor internals often sound like that 😉).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note... we also have Scheduler:
which is the time related one, unlike MessageDispatcher today which is the "run the actor" one:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The TODO there deciphered:
// TODO: we should make it dedicated to dispatch() rather than raw executing perhaps? This way it can take care of fairness thingsWhat I mean is
scheduler.execute(actorShell)rather thanscheduler.execute(mailbox.run), since then it knows which actor it's running and we can then in the future to some "locality" and "prefer the same thread as last time" etc tricks...