Fix overflow in TimeSpec addition on 32-bit architectures #1074
Conversation
|
Can one of the admins verify this patch? |
9 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
@swift-server-bot add to allowlist |
|
@swift-server-bot test this please |
|
@swift-server-bot add to allowlist |
ktoso
left a comment
ktoso
left a comment
There was a problem hiding this comment.
Thanks for the fix and trying the cluster on other platforms!
|
@swift-server-bot test this please |
|
Really flaky CI today :\ #1076 |
|
@swift-server-bot test this please |
|
Okey I'm going to merge this patch and do a follow up on the flaky test with more debug information around the events -- can't reproduce this failure but we should be able on CI and I found a good way to improve logging. |
No problem and thanks for creating this. Just trying it out now and so far I really like how this all works! |
3 participants
When Int is 32 bits, converting seconds to nanoseconds overflows. This change uses Int64 explicitly.
The change has been verified on a custom Linux armv7 system. Cross-compilation was used for the armv7 build, so I wasn't able to run the tests for that, but all tests pass on x86_64.