=receptionist lookup() trying to cast stub actor #1032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Resolves rdar://97586760 |
ktoso
commented
Jul 26, 2022
| // self.instrumentation.listingPublished(key: message._key, subscribers: 1, registrations: registrations.count) // TODO(distributed): make the instrumentation calls compatible with distributed actor based types | ||
| let guests = Set(registrations.compactMap { versioned in | ||
| versioned.actor.underlying as? Guest | ||
| try? Guest.resolve(id: versioned.actor.underlying.id as! ActorID, using: self.actorSystem) |
Member
Author
There was a problem hiding this comment.
I'll try to see if we can store the right one right away instead.
ktoso
commented
Jul 26, 2022
| typealias ActorSystem = ClusterSystem | ||
|
|
||
| // TODO: this is just to prevent a DI crash because of enums without cases and Codable | ||
| distributed func _noop() {} |
Member
Author
There was a problem hiding this comment.
wohoo, compiler no more crashing on empty DA 🥳
ktoso
changed the title
Member
Author
|
Sigh always one flaky test somewhere. Our timing is too aggressive for downing/joining, e.g. this node still was joining while we wanted it to be down in #1034 I'll spend this week tracking them all down 💯 |
ktoso
force-pushed
the
wip-distributed-receptionist-lookup-cast
branch
from
2c14c41 to
e6f2d7f
Compare
yim-lee
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Receptionist would bug out when trying to lookup() due to a wrongly implemented cast.
I'll want to enable all the other tests here and spend more time hardening for our next milestone.