Skip to content

Conversation

@ktoso
Copy link
Member

@ktoso ktoso commented Jul 25, 2022

It was reported that beta-2 toolchain errors out on the missing convenience in this init.

This is actually fixed by https://github.com/apple/swift-evolution/blob/main/proposals/0327-actor-initializers.md which @kavon implemented, so as soon as we get a stable Swift which does not need the convenience keyword we can drop it.

Adding for now to make life of early adopters easier.

It was reported that beta-2 toolchain errors out on the missing `convenience` in this init. 

This is actually fixed by https://github.com/apple/swift-evolution/blob/main/proposals/0327-actor-initializers.md which @kavon implemented, so as soon as we get a stable Swift which does not need the convenience keyword we can drop it.

Adding for now to make life of early adopters easier.
@ktoso ktoso added this to the 1.0.0-beta.2 milestone Jul 25, 2022
@ktoso
Copy link
Member Author

ktoso commented Jul 25, 2022

This will produce:

/Users/ktoso/code/swift-distributed-actors/Sources/DistributedActors/Pattern/WorkerPool.swift:87:24: warning: initializers in actors are not marked with 'convenience'; this is an error in Swift 6
    public convenience init(selector: Selector, actorSystem: ActorSystem) async throws {

but let's be ok with that until we have stable 5.7, and then we flip over and remove all those convenience

@ktoso ktoso merged commit a475135 into main Jul 25, 2022
@ktoso ktoso deleted the ktoso-patch-2 branch July 25, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants