Make public enums into structs or hide them (part 1) #1025
Conversation
|
|
||
| public static func leadershipChange(_ leadershipChange: LeadershipChange) -> Event { | ||
| .init(.leadershipChange(leadershipChange)) | ||
| } |
There was a problem hiding this comment.
Hmmm... so this one I'd kind of want to keep as an enum to be honest :\
The primary way to use it is to switch over it in an async for loop of events...
Perhaps we should do this case _PLEASE_DO_NOT_EXHAUSTIVELY_MATCH_THIS_ENUM_NEW_CASES_MIGHT_BE_ADDED_IN_THE_FUTURE trick for this one specifically... other SSWG libs do this for such cases.
There was a problem hiding this comment.
amended 7ea7b1f
Internally we just log error and/or ignore the "fake" event. Is that ok? I don't think we should do default because we will forget to update the switch when we add new event in the future. It doesn't feel right to throw error or crash either.
|
|
||
| extension OpLog.SequencedOp.SequenceRange: Codable { | ||
| public enum DiscriminatorKeys: String, Codable { | ||
| enum DiscriminatorKeys: String, Codable { |
| /// Upon noticing that this member is marked as [.down], initiate a shutdown. | ||
| public static func gracefulShutdown(delay: Duration) -> OnDownActionStrategySettings { | ||
| .init(.gracefulShutdown(delay: delay)) | ||
| } |
There was a problem hiding this comment.
good one, thank you -- yes this is a good candidate for this treatment, LGTM
|
Downing and OpLog LGTM, the Event I guess we may need to do the terrible approach instead... :-/ |
|
Flaky #971 |
2 participants
Part of #999