Distributed Actor support in Cluster Singleton #1010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
changed the title
ktoso
force-pushed
the
wip-last-singleton-step
branch
3 times, most recently
from
e73f180 to
b587d84
Compare
Member
Author
|
Let's hope I got the rebase right 🤞 |
ktoso
force-pushed
the
wip-last-singleton-step
branch
from
b587d84 to
f369625
Compare
Member
Author
|
Had to change out metrics internal API usage because of apple/swift-metrics@53be786 but good now |
Member
Author
|
Flaky cluster join - #1016 need to check it out, maybe just timing. |
Member
Author
|
@swift-server-bot test this please |
Member
Author
|
Hm same but differnet test #1018 It seems we have some timing hiccups with node joins; the singleton things working well though 🥳 I'll follow up on these tomorrow in depth. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final step for Resolves #824 cluster singleton