Codable conformances for CRDT types

[ktoso]

By doing so, when people use GSet<AnyCodable> it will automatically work without them having to implement any serializers.

I'm not yet sure if this is a requirement for the gossip -- as the manifest style serialization already helps...

But it'll be super useful for end users.

--

Note:

• we'll want to call _ensureCodableSerializers on the system whenever we register an owned type
• I'm not sure if we'll get away without calling settings.serialization.registerCodable(GSet<MyFavType>) yet... but even if, this is already a ton easier than previously with the "boxing" dance

[yim-lee]

i can help if needed

[ktoso]

Yes that’d be very welcome 🙏
I’ll kick it off with the Set and we can take it from there

[yim-lee]

Ah, I was wondering where this went. Is this something we can work on now?

[ktoso]

Yes this can be picked up. What we did here today AFAIR is that since they are proto representable they get encoded as byte blob and thus get their Codable confromance this way.

I wonder if there's a way to know if we should encode as a protocol buffers blob or implement Coding proper... Maybe by checking the superEncoder, if we know it's the blob one...?

Some open questions here...
Technically it's not blocking us since we can encode/decode them via the proto blob which is quite good but a bit meh for debugging hm...

Maybe you can have a look and we decide what we want to do here?
If it's worth reimplementing them all in terms of Codable "rather" than proto (I think not) or if worth doing in addition to (maybe? tho low priority) or doing nothing is best here.

[yim-lee]

I will take a look, though I don't have anything against protobufs (I think they might potentially be more performant for CRDTs actually) and would lean towards not reimplementing them (i.e., "do nothing").

I didn't make all CRDTs ProtoRepresentable, not sure if you did (I recall seeing LWWRegistry in .proto file)? As part of this ticket I will also check and make sure all CRDTs are covered.

[ktoso]

Yeah I think the registry was missing still 👍 Would be good to proto cover it :)

Thank you <3