Rename _CryptoExtras Take 2 #407
Conversation
|
|
||
|
|
||
| // MARK: - AES.GCM + Nonce | ||
| @available(macOS 10.15, iOS 13, watchOS 6, tvOS 13, macCatalyst 13, visionOS 1.0, *) |
There was a problem hiding this comment.
@Lukasa this was the GYB script removing all of the availability annotations - I'm not sure if this is intended or not
There was a problem hiding this comment.
It's not, those annotations should stay.
There was a problem hiding this comment.
Do you want a separate issue for the gyb file? Looks like it hasn't been touched in a while since it was Python 2.7 up to now
|
Thanks Tim, I'll review this shortly. I'm trying to get a catch-up merge to land to the wwdc-25 branch I'm afraid, and this patch will make that nearly impossible: do you mind rebuilding this shortly after that lands? #403 |
Yep no problem |
|
Ok, the branch is up-to-date, feel free to do the fixup. |
0xTim
force-pushed
the
rename-crypto-extras-2
branch
from
61239b7 to
96ccc4e
Compare
|
@Lukasa ok updated! |
Lukasa
left a comment
Lukasa
left a comment
There was a problem hiding this comment.
To minimise churn, can we add a _CryptoExtras module that only contains an @_exported import CryptoExtras? That will make it easier for folks to continue to support a wide range of versions of swift-crypto.
Won't having a product named |
|
I am...honestly not sure. Historically I've avoided wanting to do that to avoid any risk of the code being generated twice. |
|
Ok updated it, I tried to use it with JWTKit without the new module and the compiler fell over so looks like it is needed |
| @@ -0,0 +1 @@ | |||
| @_exported import CryptoExtras | |||
There was a problem hiding this comment.
This still needs a license header on it, strangely.
|
The format checker has some notes. |
|
API breakage is expected, merging over it. |
This change updates Crypto to WWDC25 equivalent code. Each of these changes were individually merged to the WWDC25 branch. This includes: - #359 - #363 - #365 - #367 - #368 - #397 - #403 - #410 - #407 - #401 - #415 --------- Co-authored-by: YourMJK <[email protected]> Co-authored-by: Si Beaumont <[email protected]> Co-authored-by: Rick Newton-Rogers <[email protected]> Co-authored-by: Raphael <[email protected]> Co-authored-by: Evan Wilde <[email protected]> Co-authored-by: Tim Condon <[email protected]> Co-authored-by: Gus Cairo <[email protected]> Co-authored-by: George Barnett <[email protected]> Co-authored-by: Fabrice de Gans <[email protected]> Co-authored-by: Wojciech Nagrodzki <[email protected]> Co-authored-by: Jesse L. Zamora <[email protected]> Co-authored-by: aryan-25 <[email protected]> Co-authored-by: Gwynne Raskind <[email protected]> Co-authored-by: 3405691582 <[email protected]> Co-authored-by: Paul Toffoloni <[email protected]>
2 participants
Following on from #281, opened as a new PR as the conflicts were too many
Checklist
If you've made changes to
gybfiles.script/generate_boilerplate_files_with_gyband included updated generated files in a commit of this pull requestMotivation:
[Explain here the context, and why you're making that change. What is the problem you're trying to solve.]
Modifications:
[Describe the modifications you've done.]
Result:
[After your change, what will change.]