Add AES CMAC support #394
Merged
Add AES CMAC support #394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation AES CMAC is a standardised albeit somewhat uncommon MAC built on top of the AES block cipher. CMAC pops up in a few places, mostly where it is convenient to assume that you have access to AES, but not to a hash function. For example, AES-SIV is built on CMAC. Modifications Add CMAC support Add tests and test vectors Result CMAC is supported
glbrntt
approved these changes
Aug 5, 2025
Contributor
glbrntt
left a comment
glbrntt
left a comment
There was a problem hiding this comment.
Two tiny things but LGTM otherwise
|
|
||
| @available(iOS 13.0, macOS 10.15, watchOS 6.0, tvOS 13.0, *) | ||
| extension AES { | ||
| public struct CMAC: @unchecked Sendable { |
Contributor
There was a problem hiding this comment.
Can you add a "why @unchecked is okay here" comment?
Sources/_CryptoExtras/AES/CMAC.swift
Outdated
Comment on lines
57
to
58
| /// - data: The data to be authenticated. | ||
| public mutating func update(bufferPointer: UnsafeRawBufferPointer) { |
Contributor
There was a problem hiding this comment.
The labels don't line up here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
AES CMAC is a standardised albeit somewhat uncommon MAC built on top of the AES block cipher. CMAC pops up in a few places, mostly where it is convenient to assume that you have access to AES, but not to a hash function. For example, AES-SIV is built on CMAC.
Modifications
Add CMAC support
Add tests and test vectors
Result
CMAC is supported