Convert APIs to async #84
Conversation
yim-lee
force-pushed
the
async-await
branch
3 times, most recently
from
eaca089 to
d15fc04
Compare
yim-lee
left a comment
yim-lee
left a comment
There was a problem hiding this comment.
This is ready for review.
|
Looking in depth now, along with apple/swift-distributed-actors#977 I think by landing both updates at the same time we can bump APIs and make them all async native etc 👍 |
Change `ping` and `pingRequest` to async and remove `onResponse` callback parameter. This change requires Swift 5.5.
|
Removed the embedded tests for now, way too much pain than they're worth -- until we get an async/await aware embedded NIO testing story (soon). Ticket here: Bring back embedded SWIMNIO tests, which are had without async-aware "Embedded" infra #86 |
|
|
||
| /// Create a new member. | ||
| public init(peer: SWIMPeer, status: SWIM.Status, protocolPeriod: UInt64, suspicionStartedAt: DispatchTime? = nil) { | ||
| public init(peer: Peer, status: SWIM.Status, protocolPeriod: UInt64, suspicionStartedAt: DispatchTime? = nil) { |
There was a problem hiding this comment.
Do we want to change suspicionStartedAt to an Instant type instead?
There was a problem hiding this comment.
I seem to remember instant isn't great for this but maybe I'm wrong...?
Sources/SWIM/Utils/time.swift
Outdated
| } | ||
|
|
||
| /// Represents number of nanoseconds within given time unit | ||
| enum PrettyTimeUnit: Int64 { |
| case nanoseconds = 1 | ||
| // @formatter:on | ||
|
|
||
| var abbreviated: String { |
Sources/SWIMNIOExample/NIOPeer.swift
Outdated
|
|
||
| public var description: String { | ||
| "SWIMNIOTimeoutError(timeout: \(self.timeout.prettyDescription), \(self.message))" | ||
| "SWIMNIOTimeoutError(timeout: \(self.timeout), \(self.message))" |
There was a problem hiding this comment.
We don't want to keep prettyDescription?
There was a problem hiding this comment.
Just because I didn't want to make a public extension with the pretty stuff on the Swift types, figured we shouldn't add public API on those
There was a problem hiding this comment.
Sorry my bad, should be fine since it is internal here
Co-authored-by: Yim Lee <[email protected]>
2 participants
Change
pingandpingRequestto async and removeonResponsecallback parameter.This change requires Swift 5.5.
DO NOT MERGE for there are broken tests