Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

loadbalancer-experimental: Thread through the EWMA half life in XdsHealthTracker #2824

Merged
merged 6 commits into from
Feb 6, 2024
Merged

loadbalancer-experimental: Thread through the EWMA half life in XdsHealthTracker #2824

merged 6 commits into from
Feb 6, 2024

Commits on Feb 5, 2024

  1. loadbalancer-experimental: Thread through the EWMA half life in XdsHe… 

    …althTracker

Motivation:

We currently set the ewma lifetime to 1 nanosecond in the
XdsHealthTracker and it's not configurable.

Modifications:

- Add a lifetime field to the OutlierDetectorConfig type
- Give it a default of 10 seconds in the Builder
    @bryce-anderson
    bryce-anderson committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    af34a27 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2024

  1. Thomas feedback

    @bryce-anderson
    bryce-anderson committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    d0f1e9f View commit details
    Browse the repository at this point in the history

  2. Fix grammar

    @bryce-anderson
    bryce-anderson committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    f92d6e1 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Thomas Kountis <[email protected]>
    @bryce-anderson @tkountis
    bryce-anderson and tkountis authored Feb 6, 2024
    Configuration menu
    Copy the full SHA
    2b494f2 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/main' into bl_anderson/ThreadEwm… 

    …aHalfLife
    @bryce-anderson
    bryce-anderson committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    1410699 View commit details
    Browse the repository at this point in the history

  5. Add back type param

    @bryce-anderson
    bryce-anderson committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    d8e0770 View commit details
    Browse the repository at this point in the history