Publisher scanWith enhancements #2640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scottmitch
requested review from
mgodave,
bryce-anderson,
tkountis and
idelpivnitskiy
Scottmitch
force-pushed
the
scan_with
branch
4 times, most recently
from
3bee92c
to
927168d
Compare
Motivation: Publisher scanWith operators only allow a limited set of mapped terminal transformations. Use cases like mapping state and preserving the onError Throwable aren't possible. Modifications: - Introduce ScanMapper and ScanLifetimeMapper which support MappedTerminal that allows all the terminal combinations to be mapped. - Deprecate ScanWithMapper and ScanWithLifetimeMapper in favor of these new APIs. - Deprecate Publisher.scanWith and Publisher.scanWithLiftime in favor of the new extension operators.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Publisher scanWith operators only allow a limited set of
mapped terminal transformations. Use cases like mapping
state and preserving the onError Throwable aren't possible.
Modifications:
support MappedTerminal that allows all the terminal combinations
to be mapped.
these new APIs.
favor of the new extension operators.