DefaultDnsClient reduce log level for TTL > max #2557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: DefaultDnsClient logs at info level if the TTL from DNS is larger than the maximum configured TTL value. This level of logging can be noisy in production and not necessarily be within the client's control.
colestanfield
approved these changes
Apr 21, 2023
...k-dns-discovery-netty/src/main/java/io/servicetalk/dns/discovery/netty/DefaultDnsClient.java
Outdated
Show resolved
Hide resolved
idelpivnitskiy
approved these changes
Apr 21, 2023
|
build failure caused by #2117 |
idelpivnitskiy
pushed a commit
that referenced
this pull request
May 2, 2023
Motivation: DefaultDnsClient logs at info level if the TTL from DNS is larger than the maximum configured TTL value. This level of logging can be noisy in production and not necessarily be within the client's control.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
DefaultDnsClient logs at info level if the TTL from DNS is larger than the maximum configured TTL value. This level of logging can be noisy in production and not necessarily be within the client's control.