H2PriorKnowledgeFeatureParityTest.serverGracefulClose ConnectionAcceptor disable offloading #2444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tor disable offloading Motivation: H2PriorKnowledgeFeatureParityTest.serverGracefulClose installs a ConnectionAcceptor which intercepts messages through the netty pipeline. However the filter is offloaded by default and may miss events. Modifications: - Override `requiredOffloads` when creating the `ConnectionAcceptorFactory` to disable offloading. Fixes: apple#2378
|
I'm not 100% sure this will resolve #2378 bcz I'm not able to reproduce locally, but seems likely given the symptoms (hang waiting for graceful closure event initiated by peer). I say we consider this as fixing and re-open if necessary. |
|
test failure attributed to #2245 |
|
Thanks for the fix. Looks reasonable. I will keep an eye on #2378. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
H2PriorKnowledgeFeatureParityTest.serverGracefulClose installs a ConnectionAcceptor which intercepts messages through the netty pipeline. However the filter is offloaded by default and may miss events.
Modifications:
requiredOffloadswhen creating theConnectionAcceptorFactoryto disable offloading.Fixes:
#2378