HostAndPort to support parsing ip+port string #2412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Parsing HostAndPort from 'ip+port' string is a common case, but we don't have tooling to support this.
servicetalk-transport-api/src/main/java/io/servicetalk/transport/api/DefaultHostAndPort.java
Show resolved
Hide resolved
servicetalk-transport-api/src/main/java/io/servicetalk/transport/api/DefaultHostAndPort.java
Outdated
Show resolved
Hide resolved
servicetalk-transport-api/src/main/java/io/servicetalk/transport/api/DefaultHostAndPort.java
Outdated
Show resolved
Hide resolved
servicetalk-transport-api/src/main/java/io/servicetalk/transport/api/DefaultHostAndPort.java
Outdated
Show resolved
Hide resolved
servicetalk-transport-api/src/main/java/io/servicetalk/transport/api/DefaultHostAndPort.java
Outdated
Show resolved
Hide resolved
Scottmitch
commented
Nov 2, 2022
| @@ -30,8 +46,86 @@ final class DefaultHostAndPort implements HostAndPort { | |||
| * @param port the port. | |||
| */ | |||
| DefaultHostAndPort(String hostName, int port) { | |||
| if (isValidIpV6Address(requireNonNull(hostName))) { // Normalize ipv6 so equals/hashCode works as expected | |||
There was a problem hiding this comment.
@idelpivnitskiy - note that I changed IPv6 do compression to be consistent in all cases.
idelpivnitskiy
approved these changes
Nov 3, 2022
servicetalk-transport-api/src/main/java/io/servicetalk/transport/api/DefaultHostAndPort.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Parsing HostAndPort from 'ip+port' string is a common case, but we don't have tooling to support this.