Always set default ServiceTalkSocketOptions#IDLE_TIMEOUT
#2174
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
It's a good practice to close excess connections if they become idle.
Modifications:
IDLE_TIMEOUT
to 5 min;@Nullable
annotation foridleTimeoutMs
in internal classes;Result:
Users always have
ServiceTalkSocketOptions#IDLE_TIMEOUT
set bydefault.
Improves default behavior in conjunctions with #2173.