Skip to content

Commit

Permalink
http-netty: Disable some GraceulConnectionClosureHandling tests (#2827)
Browse files Browse the repository at this point in the history
Motivation:

The tests are super flaky making it almost impossible to get a
clean CI run. The problem was in netty and has been fixed but
we're waiting on a release.

Modifications:

- Disable the flaky tests and add some notes to the netty dependency
  • Loading branch information
bryce-anderson authored Feb 7, 2024
1 parent 840aca3 commit db9a026
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
1 change: 1 addition & 0 deletions gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ issueManagementUrl=https://github.com/apple/servicetalk/issues
ciManagementUrl=https://github.com/apple/servicetalk/actions

# dependency versions
# on next netty upgrade re-enable the GracefulConnectionCluser tests. See issue #2117
nettyVersion=4.1.106.Final
nettyIoUringVersion=0.0.24.Final

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@
import io.servicetalk.transport.netty.internal.ExecutionContextExtension;

import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.extension.RegisterExtension;
import org.junit.jupiter.api.function.Executable;
import org.junit.jupiter.params.ParameterizedTest;
Expand Down Expand Up @@ -425,6 +426,7 @@ void closeAfterFullRequestSentNoResponseReceived(HttpProtocol protocol,
assertNextRequestFails();
}

@Disabled("Issue 2117")
@ParameterizedTest(name = "{index}: protocol={0} secure={1} initiateClosureFromClient={2} useUds={3} viaProxy={4}")
@MethodSource("data")
void closeAfterRequestMetaDataSentResponseMetaDataReceived(HttpProtocol protocol,
Expand Down Expand Up @@ -517,6 +519,7 @@ void closeAfterRequestMetaDataSentFullResponseReceived(HttpProtocol protocol,
assertNextRequestFails();
}

@Disabled("Issue 2117")
@ParameterizedTest(name = "{index}: protocol={0} secure={1} initiateClosureFromClient={2} useUds={3} viaProxy={4}")
@MethodSource("data")
void closePipelinedAfterTwoRequestsSentBeforeAnyResponseReceived(HttpProtocol protocol,
Expand Down

0 comments on commit db9a026

Please sign in to comment.