feat: add customizable chart colors via props #84
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the ability to customize chart colors (markColor, markColorFade, etc.) by passing a
chartColorsprop to the EmbeddingAtlas component. This provides flexibility for theming and branding while maintaining backward compatibility with default colors.This PR also adds theme property to EmbeddingAtlas react component, that let the clients customise embeddings view and table themes from outside.
Motivation
Users may want to customize the chart colors to match their application's theme or branding. Currently, the chart colors are hardcoded in the
chartColorsobject, making it impossible to override them without modifying the source code.Changes
ChartColorsinterface and exported it fromapi.tsfor TypeScript supportchartColorsprop toEmbeddingAtlasPropsinterfacegetChartColors()helper function to merge custom colors with defaultsChartContextto includecustomChartColorsfieldgetChartColors()EmbeddingAtlas.svelteto the chart contextExample Usage
Testing
npm run build)Checklist