make: add coverage target #685
Conversation
|
How much slower does adding |
|
Not that much. The goal is to run make integration (CLI tests) and the other tests together in a single run, serially (which wouldn’t be ideal otherwise for CI testing) |
egernst
force-pushed
the
cocov
branch
2 times, most recently
from
ffc2967 to
a843cdd
Compare
|
@katiewasnothere @dcantah - updated to add XCRUN so we get the css output for code coverage |
Makefile
Outdated
| --ignore-filename-regex=".pb.swift" \ | ||
| --ignore-filename-regex=".proto" \ | ||
| --ignore-filename-regex=".grpc.swift" \ | ||
| $(BUILD_BIN_DIR)/ContainerPackageTests.xctest/Contents/MacOS/ContainerPackageTests > $(COV_REPORT_FILE) ; \ |
There was a problem hiding this comment.
Why are we referencing xctest here? This doesn't work for me locally
There was a problem hiding this comment.
Mostly b/c this was the path for build output after running tests (make test) on my system. Maybe we can chat through this one in realtime, or others can TAL on their platform for what's unique here?
There was a problem hiding this comment.
Found the issue, I have my dev env setup on a case sensitive volume. The xctest bundle that shows up for me is at $(BUILD_BIN_DIR)/containerPackageTests.xctest/Contents/MacOS/containerPackageTests so the capitalized "ContainerPackageTests" is what's causing this to fail locally for me. Can we update the PR with the lowercase containerPackageTests?
There was a problem hiding this comment.
Ah, this makes sense - will fix.
To facilitate ability to gather code coverage metrics without slowing down our integration target, let's add a coverage target. Signed-off-by: Eric Ernst <[email protected]>
5 participants
To facilitate ability to gather code coverage metrics without slowing down our integration target, let's add a coverage target.
From this we can run
xcrun llvm-profdata mergeto get profdata and gather overall code coverage metricsType of Change
Motivation and Context
[Why is this change needed?]
Testing