Skip to content

test: Fix Windows\ImagesComparisonTests #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 27, 2022
Merged

test: Fix Windows\ImagesComparisonTests #560

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
957a95a
test: Fix Windows\ImagesComparisonTests
Dor-bl Nov 26, 2022
e0ca879
test: remove legacy LaunchApp
Dor-bl Nov 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion test/integration/Windows/ImagesComparisonTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

namespace Appium.Net.Integration.Tests.Windows
{
public class ImagesComparisonTest
public class ImagesComparisonTests
{
private WindowsDriver _calculatorSession;
protected static WebElement CalculatorResult;
Expand All @@ -19,11 +19,13 @@ public void BeforeAll()
appCapabilities.App = "Microsoft.WindowsCalculator_8wekyb3d8bbwe!App";
appCapabilities.DeviceName = "WindowsPC";
appCapabilities.PlatformName ="Windows";
appCapabilities.AutomationName= "Windows";

var serverUri = Env.ServerIsRemote() ? AppiumServers.RemoteServerUri : AppiumServers.LocalServiceUri;
_calculatorSession = new WindowsDriver(serverUri, appCapabilities,
Env.InitTimeoutSec);
_calculatorSession.Manage().Timeouts().ImplicitWait = Env.ImplicitTimeoutSec;
_calculatorSession.LaunchApp();
Copy link

@mykola-mokhnach mykola-mokhnach Nov 26, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't LaunchApp be marked as deprecated?

Copy link
Collaborator Author

@Dor-bl Dor-bl Nov 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I probably missed the memo, can you please refer me to the topic?

Copy link
Collaborator Author

@Dor-bl Dor-bl Nov 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mykola-mokhnach this one? appium/java-client#1571

Copy link
Collaborator Author

@Dor-bl Dor-bl Nov 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed it anyway

}

[OneTimeTearDown]
Expand Down