Skip to content

Conversation

@Dor-bl
Copy link
Collaborator

@Dor-bl Dor-bl commented Nov 15, 2022

Change list

Following #249
Execute unit tests as a part of CI process

Types of changes

What types of changes are you proposing/introducing to .NET client?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • New feature (non-breaking change which adds value to the project)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Documentation

  • Have you proposed a file change/ PR with appium to update documentation?

This can be done by navigating to the documentation section on http://appium.io selecting the appropriate command/endpoint and clicking the 'Edit this doc' link to update the C# example

Integration tests

  • Have you provided integration tests to pass against the beta version of appium? (for Bugfix or New feature)

Details

Please provide more details about changes if it is necessary. If there are new features you can provide code samples which show the way they
work and possible use cases. Also you can create gists with pasted C# code samples or put them here using markdown.
About markdown please read Mastering markdown and Writing on GitHub

@github-actions github-actions bot added the CI label Nov 15, 2022
@Dor-bl Dor-bl linked an issue Nov 15, 2022 that may be closed by this pull request
@Dor-bl Dor-bl added this to the v5.0.0-beta03 milestone Nov 15, 2022
Copy link
Collaborator

@laolubenson laolubenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dor-bl Wouldn't this fail all of the iOS tests? Or is this intentional

@Dor-bl
Copy link
Collaborator Author

Dor-bl commented Nov 15, 2022

@Dor-bl Wouldn't this fail all of the iOS tests? Or is this intentional

@akinsolb I've added only a specific test with this argument : --filter Name~CheckAbilityToBuildDefaultService.
I hope it works, I couldn't set up the pipeline on my repo in order to test it.

@Dor-bl Dor-bl requested a review from laolubenson November 15, 2022 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Execute unit tests as a part of CI process

3 participants