Skip to content

Conversation

@laolubenson
Copy link
Collaborator

Change list

Project file

Details

Reenabled the GeneratePackageOnBuild property because the release github action looks for a generated package for it to publish.
The file version is still removed so the assembly and package should not show an outdated version

@laolubenson
Copy link
Collaborator Author

@mykola-mokhnach This reverts a change I made in the last PR. Unable to test this before merging unfortunately

@laolubenson laolubenson added the CI label Jan 14, 2021
Copy link

@mykola-mokhnach mykola-mokhnach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would make sense to leave a comment why this should not be changed

@laolubenson laolubenson merged commit e8d3701 into appium:master Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants