Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: store curContext in createSession #483

Merged
merged 4 commits into from
Aug 14, 2019
+44 −1
Merged

fix: store curContext in createSession #483

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
306befd
fix: store curContext in createSession
KazuCocoa Aug 14, 2019
eb9ef90
add e2e for contexts
KazuCocoa Aug 14, 2019
769b35f
try to install chromedriver 2.19 for chrome 44 because of chromedrive…
KazuCocoa Aug 14, 2019
55b21c8
skip 23 since it has 44 instead of 43 for now
KazuCocoa Aug 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
try to install chromedriver 2.19 for chrome 44 because of chromedrive… 
…r error
@KazuCocoa
KazuCocoa committed Aug 14, 2019

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: 9D32E3854182E387
Learn about vigilant mode
commit 769b35f963a7013cc1f5030105365e541a2d92fa
4 changes: 2 additions & 2 deletions ci-jobs/pr-validation.yml
View file
Original file line number Diff line number Diff line change
@@ -26,5 +26,5 @@ jobs:
parameters:
script: npx mocha --timeout 6000000 --reporter mocha-multi-reporters --reporter-options config-file=./ci-jobs/mocha-config.json --recursive build/test/functional/ -g @skip-ci -i --exit
name: sdk23_e2e_tests
CHROMEDRIVER_VERSION: 2.20
ANDROID_SDK_VERSION: 23
CHROMEDRIVER_VERSION: 2.19
ANDROID_SDK_VERSION: 23