-
-
Notifications
You must be signed in to change notification settings - Fork 130
feat: add calling chrome devtools endpoint for chromium #405
Conversation
lib/protocol/routes.js
Outdated
// chromium devtools | ||
// https://chromium.googlesource.com/chromium/src/+/master/chrome/test/chromedriver/server/http_handler.cc | ||
'/session/:sessionId/goog/cdp/execute': { | ||
POST: {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and the command name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I was modifying
lib/protocol/routes.js
Outdated
|
||
// chromium devtools | ||
// https://chromium.googlesource.com/chromium/src/+/master/chrome/test/chromedriver/server/http_handler.cc | ||
'/session/:sessionId/goog/cdp/execute': { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
goog
is a vendor prefix in such case. It makes sense to replace it with a pattern matcher, like :vendor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good 👍 like it.
Chrome browser support
/session/:sessionId/goog/cdp/execute
endpoint.Selenium bindings, afaik Java, Python and Ruby, have the endpoint.
We also can support it for chromebrowser. Below is an example.
https://chromedevtools.github.io/devtools-protocol
Without this change, Appium returns below error.