build: Import CocoaAsyncSocket using Carthage

[qmfrederik]

This is an alternative to #349, but as I mentioned it gives a compile-time error and I'm not sure how it can be suppressed (other than fixing it upstream)

[KazuCocoa]

oops, I merged #349

[mykola-mokhnach]

@KazuCocoa no problems, simple create another PR to revert it

[KazuCocoa]

🆗
I've created a PR to this PR https://github.com/qmfrederik/WebDriverAgent/pull/2/files
On my local, build succeeded with the change cc @qmfrederik

[qmfrederik]

@KazuCocoa Thanks, I merged your PR. It still fails in CI, though

▸ Compiling RoutingHTTPServer.m

❌  /Users/runner/runners/2.170.1/work/1/s/Carthage/Build/iOS/CocoaAsyncSocket.framework/Headers/CocoaAsyncSocket.h:9:1: use of '@import' in framework header is discouraged, including this header requires -fmodules [-Werror,-Watimport-in-framework-header]

@import Foundation;
^



❌  /Users/runner/runners/2.170.1/work/1/s/WebDriverAgentLib/Vendor/RoutingHTTPServer/RoutingHTTPServer.h:20:9: could not build module 'CocoaAsyncSocket'

#import <CocoaAsyncSocket/GCDAsyncSocket.h>
 ~~~~~~~^

Are you using an older version of Xcode?

[KazuCocoa]

mm, I used Xcode 11.3. Let me try an older one

[qmfrederik]

I think the error is specific to Xcode 11.4. See this link: https://developer.apple.com/documentation/xcode_release_notes/xcode_11_4_release_notes?language=objc

[KazuCocoa]

quamotion#3 could be a workaround...
I was able to build this on Xcode 11.4.1

[KazuCocoa]

Note:

For Xcode 11.4+, we can specify -Wno-atimport-in-framework-header in Configurations/ProjectSettings.xcconfig to avoid the warning as qmfrederik#3 (since we should avoid the warning in Frameworks/CocoaAsyncSocket.framework)

For less than 11.3, we should not specify the flag since clang raises an error, invalid flag.

If we found a way to handle the flag dynamically, this PR is ready, I believe.

[KazuCocoa]

Like https://github.com/qmfrederik/WebDriverAgent/pull/3/files , when I added -Wno-atimport-in-framework-header as a flag for the xcodebuild, it was able to build for both 11.4+ and 11.3-.
We need to update documentation about building manually (add below), but it seems reasonable with Carthage so far.

#if __has_warning("-Watimport-in-framework-header")	
#pragma clang diagnostic ignored "-Watimport-in-framework-header"	
#endif

[mykola-mokhnach]

Cannot we simply push a PR to https://github.com/robbiehanson/CocoaAsyncSocket ?

I hope @robbiehanson would be happy to merge it ASAP

[qmfrederik]

I've created robbiehanson/CocoaAsyncSocket#723. Let's see how it goes.

[KazuCocoa]

Updated with the CocoaAsyncSocket fix
quamotion#3

[mykola-mokhnach]

I would say this is not necessary anymore after GCDAsyncSocket bump

[KazuCocoa]

yey