add skipLogCapture #355
Merged
add skipLogCapture #355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
lib/driver.js
Outdated
| this.localConfig = await setLocaleAndPreferences(this.sim, this.opts, this.isSafari(), endSimulator); | ||
| await this.startLogCapture(this.sim); | ||
| if (this.caps.skipLogCapture) { | ||
| logger.info("'skipLogCapture' is set. Skipping starting logs, crash and system."); |
Contributor
There was a problem hiding this comment.
Skipping starting logs, crash and system. - this sentence looks confusing. Can we rephrase it?
lib/driver.js
Outdated
| await this.createInstruments(); | ||
| await runRealDeviceReset(this.realDevice, this.opts); | ||
| await this.startLogCapture(); | ||
| if (this.caps.skipLogCapture) { |
Contributor
There was a problem hiding this comment.
Please move it to a common method to avoid unnecessary duplication
lib/driver.js
Outdated
|
|
||
| async setUpLogCapture () { | ||
| if (this.caps.skipLogCapture) { | ||
| logger.info("'skipLogCapture' is set. Skipping starting logs, crash and system."); |
Contributor
There was a problem hiding this comment.
Skipping the collection of system logs and crash reports.
mykola-mokhnach
approved these changes
Feb 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
appium/appium#12203 (comment)