Skip to content

docs: add "the mvp works!" to README.md - #13

Closed
ghost wants to merge 1 commit into
mainfrom
agent/12-add-mvp-works-readme
Closed

ghost wants to merge 1 commit into
mainfrom
agent/12-add-mvp-works-readme

Conversation

@ghost

@ghost ghost commented Apr 22, 2026

Copy link
Copy Markdown

Add the requested phrase to the end of README.md as specified in the issue.

Closes #12

Changed files

  • README.md

Closes #12

Post-script verification

  • Branch is not main/master (agent/12-add-mvp-works-readme)
  • No protected paths modified
  • Secret scan passed (gitleaks — 35f70e72dc4bf27b3afe500457de462904912161..HEAD)
  • Pre-commit hooks passed (authoritative run on runner)
  • Tests ran inside sandbox

Created by fullsend code agent

Add the requested phrase to the end of README.md as specified
in the issue.

Closes #12
@ghost ghost added the ready-for-review Agent PR ready for human review label Apr 22, 2026
@ghost

ghost commented Apr 22, 2026

Copy link
Copy Markdown

Review: #13

Head SHA: d305c5f
Outcome: failure
Reason: missing-context — required scan-unicode tool not found at $SCAN_UNICODE (/tmp/workspace/bin/scan-unicode). Cannot complete injection defense checks without it.

This PR was NOT reviewed. Do not count this as an approval.

ralphbean added a commit to fullsend-ai/fullsend that referenced this pull request Apr 23, 2026
The GitHub Contents API (used by admin install) commits all files as
100644, so scripts like scan-unicode lose their executable bit in the
.fullsend repo. When bootstrapEnv() copies these into the sandbox via
SCP, they remain non-executable and `test -x` fails.

Work around this by forcing chmod +x on any host_file whose destination
is under a bin/ directory. This is a stopgap until admin install
preserves the git tree mode (see #312).

Fixes: appdumpster/test-repo#13 review failure

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gbenhaim pushed a commit to gbenhaim/fullsend that referenced this pull request Apr 27, 2026
The GitHub Contents API (used by admin install) commits all files as
100644, so scripts like scan-unicode lose their executable bit in the
.fullsend repo. When bootstrapEnv() copies these into the sandbox via
SCP, they remain non-executable and `test -x` fails.

Work around this by forcing chmod +x on any host_file whose destination
is under a bin/ directory. This is a stopgap until admin install
preserves the git tree mode (see fullsend-ai#312).

Fixes: appdumpster/test-repo#13 review failure

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions github-actions Bot closed this Apr 30, 2026
@github-actions
github-actions Bot deleted the agent/12-add-mvp-works-readme branch April 30, 2026 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-review Agent PR ready for human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add "the mvp works!" to the README.md

0 participants