Open master merge #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix deprecation warning for contructing new BigDecimal
This commit sets up CircleCI for combinations of ruby 2.6/2.5, mongoid, ActiveRecord 6.0/5.2. It also marks some specs as pending, as they are not allowed in elasticsearch now. They will be addressed in a separate PR.
Setup CI on CircleCI
Allow configuration of Active Job queue name
Added Ruby 2.7 to CircleCI config
Fixed deprecation warnings in Ruby 2.7
Fixes deprecation warnings ``` warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call ``` 1. Fixed warning when calling `response.records`, warning backtrace: ``` # gems/2.7.0/bundler/gems/chewy-74470f2525b2/lib/chewy/search/loader.rb:55:in `block in load' # gems/2.7.0/bundler/gems/chewy-74470f2525b2/lib/chewy/search/loader.rb:50:in `each' # gems/2.7.0/bundler/gems/chewy-74470f2525b2/lib/chewy/search/loader.rb:50:in `each_with_object' # gems/2.7.0/bundler/gems/chewy-74470f2525b2/lib/chewy/search/loader.rb:50:in `load' # gems/2.7.0/bundler/gems/chewy-74470f2525b2/lib/chewy/search/response.rb:85:in `objects' ``` 2. Fixed warning when calling `SomeIndex.reset!((Time.now.to_f * 1000).round)`, warning backtrace: ``` # gems/chewy-74470f2525b2/lib/chewy/type/adapter/active_record.rb:25:in `import_scope' # gems/chewy-74470f2525b2/lib/chewy/type/adapter/orm.rb:79:in `import' # gems/chewy-74470f2525b2/lib/chewy/type/import.rb:142:in `block in import_linear' # /home/aglushkov/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/activesupport-6.0.3.4/lib/active_support/notifications.rb:180:in `block in instrument' # /home/aglushkov/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/activesupport-6.0.3.4/lib/active_support/notifications/instrumenter.rb:24:in `instrument' # /home/aglushkov/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/activesupport-6.0.3.4/lib/active_support/notifications.rb:180:in `instrument' # gems/chewy-74470f2525b2/lib/chewy/type/import.rb:141:in `import_linear' # gems/chewy-74470f2525b2/lib/chewy/type/import.rb:136:in `import_routine' # gems/chewy-74470f2525b2/lib/chewy/type/import.rb:76:in `import' # gems/chewy-74470f2525b2/lib/chewy/index/actions.rb:149:in `block in import' # gems/chewy-74470f2525b2/lib/chewy/index/actions.rb:147:in `map' # gems/chewy-74470f2525b2/lib/chewy/index/actions.rb:147:in `import' # gems/chewy-74470f2525b2/lib/chewy/index/actions.rb:182:in `reset!' ``` 3. Same `SomeIndex.reset!((Time.now.to_f * 1000).round)`, warning backtrace: ``` # gems/2.7.0/bundler/gems/chewy-74470f2525b2/lib/chewy/type/import.rb:130:in `new' # gems/2.7.0/bundler/gems/chewy-74470f2525b2/lib/chewy/type/import.rb:130:in `import_routine' # gems/2.7.0/bundler/gems/chewy-74470f2525b2/lib/chewy/type/import.rb:76:in `import' # gems/2.7.0/bundler/gems/chewy-74470f2525b2/lib/chewy/index/actions.rb:149:in `block in import' # gems/2.7.0/bundler/gems/chewy-74470f2525b2/lib/chewy/index/actions.rb:147:in `map' # gems/2.7.0/bundler/gems/chewy-74470f2525b2/lib/chewy/index/actions.rb:147:in `import' # gems/2.7.0/bundler/gems/chewy-74470f2525b2/lib/chewy/index/actions.rb:182:in `reset!' ```
Fix instructions for AWS ElasticSearch configuration in README as it is outdated.
Seems we're blocked by rspec/rspec-mocks#1394 This reverts commit da4ff3e.
Thanks to @rabotyaga for the solution
Update Rails version in CI matrix
…ning Patch ElasticSearch deprecation warning
Add support for Ruby 3
Fix incorrect mention of version release 7.3.5; the second occurrence should be 7.3.6.
Mainly useful to avoid flaky tests when using a real redis database and not flushing the database in between tests
Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.48.0...v1.60.0) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.60.0...v1.60.1) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Make default index scope cleanup behavior configurable Instead of warning, you can completely ignore cases when the scope include order/offset/limit or you can raise an exception instead. * Update changelog
Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.60.1...v1.60.2) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.60.2...v1.61.0) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.61.0...v1.62.1) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.62.1...v1.63.0) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Update rubocop requirement from 1.63.0 to 1.63.2 Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.63.0...v1.63.2) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> * Fix specs --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Samuel Ebeagu <[email protected]>
Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.63.2...v1.63.3) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Relax allowed `elasticsearch` dependency version * Update tracer/logger access style * Add changelog notes
* Fix intermittent time-based failure in delayed sidekiq spec This example was previously failing when it was run at exactly an "even" 10 second increment time. For example, it would fail at "12:00:10", but pass at "12:00:09" and "12:00:11". This leads to intermittent failures on CI (presumably around ~10% of runs). Updated to use a helper method in the spec which more closely mirrors the scheduler code. * Add changelog notes
Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.63.3...v1.63.4) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.63.4...v1.63.5) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Update rubocop requirement from 1.63.5 to 1.64.1 Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.63.5...v1.64.1) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> * Fix rubocop --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Samuel Ebeagu <[email protected]>
Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.64.1...v1.65.0) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.65.0...v1.65.1) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* ES 8.x upgrade * Fix termnite after changes * fixup es * Elastic security on: configuration example * Mass index deletion disabled by default in Elastic * Elastic docker file: increase sleep, bump image * Spec fixes * bump dependency * Bump version, update docs --------- Co-authored-by: Danil Nurgaliev <[email protected]>
* Fix id conversion issue in delayed_sidekiq strategy Ensure ids extracted from Redis remain strings, preventing UUID issues. Previously, ids were being converted to integers, causing problems with UUIDs in the `delayed_sidekiq` strategy. This update also enhances the test suite: - Existing tests are updated. - A new test ensures the issue is resolved. Due to SQLite's lack of UUID support, a `stub_uuid_model` method is added. This method stubs models with UUIDs, using `SecureRandom.uuid` for the primary key. Move table creations to individual methods. Having every table creation inside a single block casued Rubocop `Metrics/BlockLength` error. To fix it I moved each table creation to an individual method. * Add changelog notes --------- Co-authored-by: Sundus Yousuf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.