Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: proper configuration error messages #995

Merged
merged 2 commits into from
Feb 11, 2022
Merged

fix: proper configuration error messages #995

merged 2 commits into from
Feb 11, 2022

Conversation

EverlastingBugstopper
Copy link
Contributor

This PR does two things:

  1. Use $APOLLO_KEY when there are no profiles
  • to achieve this, we now only parse environment variables at startup and store them on first load in a LazyCell
  1. Correctly print error E020 when there are no profiles on the machine, fixes Improve errors and messages when you haven't configured auth at all #783

@EverlastingBugstopper EverlastingBugstopper changed the title Avery/no profile config fix: proper configuration error messages Feb 11, 2022
@EverlastingBugstopper EverlastingBugstopper self-assigned this Feb 11, 2022
@EverlastingBugstopper EverlastingBugstopper added the fix 🩹 fixes a bug label Feb 11, 2022
@EverlastingBugstopper EverlastingBugstopper added this to the 0.4.2 or 0.5.0 milestone Feb 11, 2022
@EverlastingBugstopper EverlastingBugstopper merged commit ff44aeb into main Feb 11, 2022
@EverlastingBugstopper EverlastingBugstopper deleted the avery/no-profile-config branch February 11, 2022 19:11
This was referenced Feb 11, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrlna lrlna Awaiting requested review from lrlna

Assignees

@EverlastingBugstopper EverlastingBugstopper

Labels
fix 🩹 fixes a bug
Projects
None yet
Milestone
0.4.2
Development

Successfully merging this pull request may close these issues.

Improve errors and messages when you haven't configured auth at all
1 participant
@EverlastingBugstopper