Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve messaging for rover subgraph check #980

Conversation

david-castaneda
Copy link
Contributor

@david-castaneda david-castaneda commented Feb 2, 2022

Motivation

The current message outputted by rover when running a subgraph check only tells you if the API schema changed not the core schema.

This can sometimes lead to a confusing experience. For example when adding metadata directives such as @key, @tag etc. which get removed during composition and then seeing that rover detected zero changes.

The proposed improvement is the following.

If the Core schema changed but the API schema did not change:

There were no changes detected in the composed API schema, but the core schema was modified.

If the Core and API schema did not change:

There were no changes detected in the composed schema.

Copy link
Contributor

@EverlastingBugstopper EverlastingBugstopper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great! thanks for submitting this @david-castaneda

@EverlastingBugstopper EverlastingBugstopper merged commit d0e6b53 into apollographql:main Feb 8, 2022
@EverlastingBugstopper EverlastingBugstopper added this to the 0.4.2 or 0.5.0 milestone Feb 8, 2022
This was referenced Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants