Improve messaging for rover subgraph check
#980
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The current message outputted by rover when running a
subgraph check
only tells you if the API schema changed not the core schema.This can sometimes lead to a confusing experience. For example when adding metadata directives such as
@key
,@tag
etc. which get removed during composition and then seeing that rover detected zero changes.The proposed improvement is the following.
If the Core schema changed but the API schema did not change:
There were no changes detected in the composed API schema, but the core schema was modified.
If the Core and API schema did not change:
There were no changes detected in the composed schema.