feat(composition): default to routing url from graph registry #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EverlastingBugstopper
force-pushed
the
avery/fixup-supergraph-compose
branch
3 times, most recently
from
73fbef3
to
6c6b21c
Compare
EverlastingBugstopper
force-pushed
the
avery/fixup-supergraph-compose
branch
from
6c6b21c
to
2b08980
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back in #519 we had a
TODOto default to the routing URL in the graph registry for a subgraph when doingsupergraph composelocally. This PR makes that happen - might be considered a breaking change? maybe? if you like, somehow relied on leavingrouting_urlblank and had something in the graph registry, that url will now be used. quick workaround is to just setrouting_url = ""if for some reason you really must omit URLs from your supergraph SDL.In all reality this is more like a "fixing" change where we'll just "do the right thing" by getting the url from the registry, or errors will show up rather than producing invalid supergraph SDL without the URLs.