Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(xtask): refactor tool runners & e2e test supergraph demo #629

Merged
merged 3 commits into from
Jun 23, 2021

Conversation

EverlastingBugstopper
Copy link
Contributor

@EverlastingBugstopper EverlastingBugstopper commented Jun 22, 2021

The first commit is a refactor that cleans up a bit of rushed xtask code.

The second/third commit is the following:

  1. Iff running on GNU linux
  2. clone https://github.com/apollographql/supergraph-demo into a temp directory
  3. run make ci
  4. assert that the output includes the following output:
"🚀 Graph Router ready at http://localhost:4000/", "allProducts",  and "Removing network"

There is an argument to be made here that supergraph-demo should live as a subdirectory in rover if we want it to be part of our test suite, but figured that this was an easier path forward and lets us keep git history intact w/o resorting to the hellscape that is git submodules.

These tests will only run in cargo xtask test commands and not cargo test commands, so they should not be too much of a burden for the average contributor (they don't need to install make or docker or anything if they just run cargo test).

@EverlastingBugstopper EverlastingBugstopper changed the title (wip) chore(xtask): refactor tool runners & e2e test supergraph demo chore(xtask): refactor tool runners & e2e test supergraph demo Jun 23, 2021
@EverlastingBugstopper EverlastingBugstopper merged commit ec747e8 into main Jun 23, 2021
@EverlastingBugstopper EverlastingBugstopper deleted the avery/e2e-test branch June 23, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant