feat(rover): output service title for whoami #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrlna
requested review from
EverlastingBugstopper and
JakeDawkins
as code owners
In our discussions we found that Name was not a useful piece of information to show to Rover's users. Instead, this commit introduces a Service title which is aligned with the information that Studio displays for a user.
lrlna
force-pushed
the
lrlna/whoami-title
branch
from
fcfbc30
to
447cc03
Compare
lrlna
commented
Feb 22, 2021
|
|
||
| let title = match me.on { | ||
| who_am_i_query::WhoAmIQueryMeOn::Service(s) => s.title, | ||
| _ => "No Title".to_string(), |
There was a problem hiding this comment.
Happy to have No Title as something else, if that doesn't sound suitable.
There was a problem hiding this comment.
I doubt we'll see this case often (if ever?), but regardless, I think this is fine :)
There was a problem hiding this comment.
Ah, I see what's going on here. It's printing service title regardless of whether it's a service key or not. I think I'm going to push a commit changing that, feel free to reject it or push back tomorrow :)
There was a problem hiding this comment.
Ah, yea this new commit you pushed works well. Merging the PR in.
|
I changed the printout to handle user and graph keys differently. |
JakeDawkins
added
the
feature 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In our discussions we found that Name was not a useful piece of
information to show to Rover's users. Instead, this commit introduces
a Service title which is aligned with the information that Studio
displays for a given user.
closes #280