feat: adds support for big sur in curl installer #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EverlastingBugstopper
requested review from
JakeDawkins and
lrlna
as code owners
EverlastingBugstopper
force-pushed
the
avery/test-big-sur
branch
from
91d5a6d
to
d1ded73
Compare
JakeDawkins
added
feature 🎉
lrlna
reviewed
Feb 22, 2021
| @@ -86,6 +86,13 @@ get_architecture() { | |||
| fi | |||
| fi | |||
|
|
|||
| if [ "$_ostype" = Darwin -a "$_cputype" = arm64 ]; then | |||
| # Darwin `uname -s` doesn't seem to lie on Big Sur | |||
lrlna
approved these changes
Feb 22, 2021
This was referenced Feb 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #295 by providing an x86_64 binary for the Big Sur arm64 machines. This works because those machines can run x86_64 code in emulation mode which is really cool and I'm much less upset with Apple now that I understand what's actually going on.
Shoutout to @benjamn and @JakeDawkins for helping me to confirm that this works on both M1 machines and the older intel machines.
we will still need to figure out signing our MacOS binaries in order for this to work but we shouldn't need any additional CI runners or anything like that.
this PR also does not include any changes to our npm installer, which i'm guessing we will need. similar change to this one, feature detect an M1 macbook and make it not complain about not supporting arm64 by directing them to the x86_64 binary.