Skip to content

Auto-configure MCP server endpoint with router's custom path#2869

Merged
DaleSeo merged 3 commits intomainfrom
AIR-55
Nov 24, 2025
Merged

Auto-configure MCP server endpoint with router's custom path#2869
DaleSeo merged 3 commits intomainfrom
AIR-55

Conversation

@DaleSeo
Copy link
Member

@DaleSeo DaleSeo commented Nov 14, 2025

When users configure a custom path in their router config (e.g., supergraph.path: /graphql), the MCP server fails to connect to the router with error code -32603. This occurs because Rover was not including the custom path when setting the APOLLO_MCP_ENDPOINT environment variable for the MCP server.

This PR makes rover dev automatically detect and use the router's custom path when configuring the MCP server endpoint. The router configuration becomes the single source of truth for both Router and Apollo MCP server.

@DaleSeo DaleSeo self-assigned this Nov 14, 2025
@DaleSeo DaleSeo force-pushed the AIR-55 branch 2 times, most recently from 3a5265a to 5bcc7a4 Compare November 14, 2025 22:41
@DaleSeo DaleSeo marked this pull request as ready for review November 14, 2025 22:42
@DaleSeo DaleSeo requested a review from a team November 14, 2025 22:42
Copy link
Contributor

@naomijub naomijub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the path ambiguity LGTM

@apollo-librarian
Copy link
Contributor

apollo-librarian bot commented Nov 18, 2025

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: 35f72099c049c6639e47adcc
Build Logs: View logs

@DaleSeo DaleSeo requested a review from naomijub November 18, 2025 15:41
@DaleSeo DaleSeo added this pull request to the merge queue Nov 24, 2025
Merged via the queue into main with commit 799c506 Nov 24, 2025
33 checks passed
@DaleSeo DaleSeo deleted the AIR-55 branch November 24, 2025 18:59
@DaleSeo DaleSeo added this to the v0.36.3 milestone Nov 26, 2025
@DaleSeo DaleSeo added feature 🎉 new commands, flags, functionality, and improved error messages fix 🩹 fixes a bug and removed feature 🎉 new commands, flags, functionality, and improved error messages labels Nov 26, 2025
@DaleSeo DaleSeo mentioned this pull request Nov 26, 2025
github-merge-queue bot pushed a commit that referenced this pull request Dec 2, 2025
# [0.37.0] - 2025-12-01

## 🚀 Features

- **Enable overriding MCP version in `rover dev` - @DaleSeo, PR #2784**

## 🐛 Fixes

- **Remove conditional header in VSCode file from MCP template
processing - @gocamille, PR #2757**
- **Auto-configure MCP server endpoint with router's custom path-
@naomijub, PR #2869**

## 📚 Documentation

- **change MCP's default port from 5000 to 8000 - @DaleSeo, PR #2749**
github-merge-queue bot pushed a commit that referenced this pull request Dec 8, 2025
As a quick follow-up on PR #2869, I just wanted to add a unit test to
verify that `rover dev` automatically detects and overrides any
user-specified `APOLLO_MCP_ENDPOINT` environment variable.
github-merge-queue bot pushed a commit that referenced this pull request Dec 8, 2025
As a quick follow-up on PR #2869, I just wanted to add a unit test to
verify that `rover dev` automatically detects and overrides any
user-specified `APOLLO_MCP_ENDPOINT` environment variable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix 🩹 fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants