WIP: rover lsp
#2135
Draft
WIP: rover lsp
#2135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trevor-scheer
force-pushed
the
language-server
branch
2 times, most recently
from
ab02b4b
to
7e12040
Compare
dylan-apollo
force-pushed
the
language-server
branch
from
7e12040
to
b011c6c
Compare
| @@ -156,3 +156,15 @@ impl<E: Into<anyhow::Error>> From<E> for RoverError { | |||
| Self::new(error) | |||
| } | |||
| } | |||
|
|
|||
| impl From<RoverError> for BuildErrors { | |||
There was a problem hiding this comment.
maybe TryFrom instead of From to avoid the panic and let the caller deal with the error?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.